Open in app

Sign In

Write

Sign In

Curtis Einsmann
Curtis Einsmann

1.4K Followers

Home

About

Pinned

I’ve code reviewed over 750 pull requests at Amazon. Here’s my exact thought process.

Disclaimer: I’m not representing Amazon in any way. Opinions written here are strictly my own. I’ve code reviewed over 750 pull requests in my 5-year software engineer career at Amazon. As my team’s tech lead I provide insightful feedback and encourage a high code quality bar. But as a junior…

Software Engineering

4 min read

I’ve code reviewed over 750 pull requests at Amazon. Here’s my exact thought process.
I’ve code reviewed over 750 pull requests at Amazon. Here’s my exact thought process.
Software Engineering

4 min read


Nov 30, 2022

How to nitpick on code reviews with empathy

You’re reviewing a Pull Request. You see a variable that should be renamed. Or a comment that should be rephrased. Or some if/else logic that could be a guard clause. Should you comment on the PR, or let it go? My answer: in most cases, yes, you should leave a…

Code Review

3 min read

How to nitpick on code reviews with empathy
How to nitpick on code reviews with empathy
Code Review

3 min read


Nov 30, 2022

Take more photos, it will change your life

For the past few years, I’ve dedicated just 30 minutes a month to organizing my photos. It’s had an incredibly positive impact on my life’s enjoyment. In this post, I’ll share my system which motivates me to take more photos. Have you ever gone on a trip, been to an…

Photos

6 min read

Take more photos, it will change your life
Take more photos, it will change your life
Photos

6 min read


Sep 12, 2022

Code reviews? What about pair programming, and trunk-based development?

I post about code reviews often. For example: how to review pull requests, how to author pull requests, and how to force multiply your code review process. Often, I get feedback like this: “We should forget about pull requests, embrace pair programming, and adopt trunk-based development!” In this post, I’ll…

Software Engineering

6 min read

Code reviews? What about pair programming, and trunk-based development?
Code reviews? What about pair programming, and trunk-based development?
Software Engineering

6 min read


Jun 30, 2022

The $13,000 launch of my code review course

Several months ago I launched my first info product, a video course called Master the Code Review. I built it from scratch, on my own, and from my own ideas. So far it’s done over $23K in revenue, with $13K in the first month. I’m not writing this to flex…

Software Engineering

11 min read

The $13,000 launch of my code review course
The $13,000 launch of my code review course
Software Engineering

11 min read


Apr 3, 2022

Code reviews intimidated me. So I built a course to help developers master them.

Last month I launched my first ever video course. It’s done $17K in revenue, and it’s helped over 500 developers Master the Code Review. But I didn’t build it for them — I built it for the me of the past. …

Software Engineering

5 min read

Code reviews intimidated me. So I built a course to help developers master them.
Code reviews intimidated me. So I built a course to help developers master them.
Software Engineering

5 min read


Mar 25, 2022

From an ex-Amazon team lead: 5 mistakes I made as a junior software engineer

I was a software development engineer at Amazon Web Services for 6 years. I started as an intern. I grew to be a tech lead for various teams and projects. During my time at AWS, I directly mentored over a dozen junior software engineers. …

Software Engineering

4 min read

From an ex-Amazon team lead: 5 mistakes I made as a junior software engineer
From an ex-Amazon team lead: 5 mistakes I made as a junior software engineer
Software Engineering

4 min read


Feb 13, 2022

Most teams are doing code reviews wrong. Here are 3 warning signs, and 3 fixes.

Software engineers engage in code reviews daily. Some teams have a great code review process. Others could use improvement. Here are 3 signs of a bad code review process, and how your team can ship better software, faster. 3 signs of a bad code review process 🚩 If code reviews make you, or other developers, anxious. Likely, reviewers aren’t prioritizing kindness. …

Software Engineering

4 min read

Most teams are doing code reviews wrong. Here are 3 warning signs, and 3 fixes.
Most teams are doing code reviews wrong. Here are 3 warning signs, and 3 fixes.
Software Engineering

4 min read


Nov 29, 2021

Soft skills help developers level up. Here are the 10 I’d tell my junior self.

As a developer, technical skills are important. But soft skills are key to level up — and they’re often overlooked. In 6 years, I went from intern to lead software engineer. I excelled in an organization known for hiring stellar tech talent. During this time I read more than 150…

Software Engineering

4 min read

Soft skills help developers level up. Here are the 10 I’d tell my junior self.
Soft skills help developers level up. Here are the 10 I’d tell my junior self.
Software Engineering

4 min read


Nov 4, 2021

How I craft beautiful code that gets approved on the first review

At the start of my career I’d open a code review (a.k.a., Pull Request) and receive 50+ comments. I’d open a second revision, only to receive another 30. It often took 8, 9, even 10 reviews to get my code approved. My code had some serious flaws and readability gaps…

Software Engineering

5 min read

How I craft beautiful code that gets approved on the first review
How I craft beautiful code that gets approved on the first review
Software Engineering

5 min read

Curtis Einsmann

Curtis Einsmann

1.4K Followers

Software engineer, writing to help developers level up. All stories free. Follow me on Twitter for more: https://twitter.com/curtiseinsmann

Following
  • Milos Zivkovic

    Milos Zivkovic

  • Dan Goslen

    Dan Goslen

  • Michael Lin

    Michael Lin

  • Catalin's Tech

    Catalin's Tech

  • Cory Einsmann

    Cory Einsmann

See all (37)

Help

Status

Writers

Blog

Careers

Privacy

Terms

About

Text to speech

Teams