I’ve code reviewed over 750 pull requests at Amazon. Here’s my exact thought process.

I understand why code reviews matter.

I’ve taken the time to learn programming principles.

I review the PR slowly.

I start with the crux.

I read randomly until I achieve deep understanding.

I read class by class.

I comment with kindness.

I comment with accuracy.

  1. The problem with the code.
  2. The reason why I perceive it to be a problem.
  3. My recommendation for how the author can resolve it.

I approve when the PR is good, not perfect.

I seek feedback for whether I’m reviewing well.

Like this article? It started on Twitter. Follow me for more! Here’s an example of what to expect:

--

--

--

Software engineer; solopreneur. Writing to help developers level up. All stories free. Follow me on Twitter for more: https://twitter.com/curtiseinsmann

Love podcasts or audiobooks? Learn on the go with our new app.

Recommended from Medium

Understanding the “What, Why and How?” of CI/CD

Create your own cloud module for the Serverless Multi-Cloud Framework

DEPLOYING WORDPRESS WEBSITE ON GCP CLOUD USING SQL AND GKE

Using Google Cloud Service Accounts on GKE | by Nick Joyce | Real Kinetic  Blog

What I done did in August 2020

Say NO to Refactoring Data Models!

Bedrock Hot Wheels Acceleracers — Hollowback — Metal Maniacs

How to Implement a Binary Heap (Javascript)

My Favorite New Features in Python 3.8

Get the Medium app

A button that says 'Download on the App Store', and if clicked it will lead you to the iOS App store
A button that says 'Get it on, Google Play', and if clicked it will lead you to the Google Play store
Curtis Einsmann

Curtis Einsmann

Software engineer; solopreneur. Writing to help developers level up. All stories free. Follow me on Twitter for more: https://twitter.com/curtiseinsmann

More from Medium

How to become an awesome engineer

Senior Software Engineer

Software Engineering in a nutshell

Planning a Software Feature

Empty mind map