Disclaimer: I’m not representing Amazon in any way. Opinions written here are strictly my own.

I’ve code reviewed over 750 pull requests in my 5-year software engineer career at Amazon. As my team’s tech lead I provide insightful feedback and encourage a high code quality bar.

But as a junior engineer I was a poor reviewer. I didn’t know where to start, what to look for or how to comment. I gave useless comments on style. I rushed through reviews giving the classic “LGTM!” after missing obvious flaws.

What follows is my thought process on how I review pull requests…

Disclaimer: I’m not representing Amazon in any way. Opinions written here are strictly my own.

Today I celebrate my 5 year anniversary at Amazon.

I’ve contributed more than 500,000 lines of code to production systems. I’ve authored and shipped more than 500 code reviews.

I’ve designed, developed, deployed and maintained large scale software systems used by thousands of customers all over the world.

I’m recognized as one of the key technical leaders on my team.

It wasn’t always this way, though.

In 2015, I was hired as a Software Development Engineer 1.

I shouldn’t have been hired. …

Curtis Einsmann

Amazon software engineer sharing soft skills. Opinions mine. https://twitter.com/curtiseinsmann

Get the Medium app

A button that says 'Download on the App Store', and if clicked it will lead you to the iOS App store
A button that says 'Get it on, Google Play', and if clicked it will lead you to the Google Play store